This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Add gh-team-whitelist command line argument
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Oct 12, 2018
.travis.yml
Outdated
| - make go:deps-dev | ||
|
|
||
| script: | ||
| - make go:deps |
osterman
reviewed
Oct 12, 2018
Makefile
Outdated
| @@ -86,3 +86,9 @@ end-to-end-tests: ## Run e2e tests | |||
|
|
|||
| website-dev: | |||
| yarn website:dev | |||
|
|
|||
| go-get: | |||
osterman
reviewed
Oct 12, 2018
Makefile
Outdated
| go-get: | ||
| go get | ||
|
|
||
| go-build: |
There was a problem hiding this comment.
let's use go/build (e.g. like our docker/build)
|
We've merged #9 which does the same thing but uses |
goruha
approved these changes
Jan 7, 2019
goruha
suggested changes
Jan 7, 2019
|
this was implemented and merged in #9 |
|
Will setting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
gh-team-whitelistcommand line argumentwhy
{team}:{command},{team}:{command}, e.g.--gh-team-whitelist=dev:plan,ops:apply,devops:*. This example means to give the users from thedevGitHub team the permissions to execute theplancommand, give theopsteam the permissions to execute theapplycommand, and allow thedevopsteam to perform any operation*:*) will be used and the default behavior will be to not check permissions and to allow users from any team to perform any operation